Open
Conversation
anathan
force-pushed
the
add-config-wizard
branch
from
3ac923f to
584b70a
Compare
anathan
force-pushed
the
add-config-wizard
branch
from
28fd1db to
8a63d3e
Compare
adamshapiro0
reviewed
Jan 2, 2026
adamshapiro0
reviewed
Jan 2, 2026
adamshapiro0
reviewed
Jan 2, 2026
adamshapiro0
reviewed
Jan 2, 2026
adamshapiro0
reviewed
Jan 2, 2026
adamshapiro0
reviewed
Jan 2, 2026
adamshapiro0
reviewed
Jan 2, 2026
adamshapiro0
requested changes
Jan 2, 2026
Collaborator
adamshapiro0
left a comment
adamshapiro0
left a comment
There was a problem hiding this comment.
This looks ok generally but I'd strongly recommend we unify the device specifier syntax and code between the tools. Right now this tool and config_tool.py have similar-looking formats that aren't actually the same, and this tool doesn't handle baud rate (or websocket).
updates readme and clarifies some language adds spaces for units adds configurable serial baud, minor reademe tweaks
anathan
force-pushed
the
add-config-wizard
branch
from
153a6fe to
d8edfbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it easier for users to configure our INS products without reading the manual :)